Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when using remark plugins using external processes #73

Closed
cdfa opened this issue Sep 24, 2019 · 2 comments
Closed

Error when using remark plugins using external processes #73

cdfa opened this issue Sep 24, 2019 · 2 comments
Assignees
Labels
external known issue from external, can't do much by ourselves good first issue 👋 This may be a great place to get started! help wanted 🙏 This could use your insight or help
Milestone

Comments

@cdfa
Copy link

cdfa commented Sep 24, 2019

I don't know how much can be done about this, but using remark plugins that use external processes (like remark-lint-no-dead-urls or remark-preset-github) throws the following error:

$ npx eslint README.md
Error: `processSync` finished async. Use `process` instead
Occurred while linting /home/cdfa/Projects/react-turn-reveal/README.md:1
at assertDone (/home/cdfa/Projects/react-turn-reveal/node_modules/.registry.npmjs.org/unified/8.4.0/node_modules/unified/index.js:459:11)
at Function.processSync (/home/cdfa/Projects/react-turn-reveal/node_modules/.registry.npmjs.org/unified/8.4.0/node_modules/unified/index.js:391:5)
at Program (/home/cdfa/Projects/react-turn-reveal/node_modules/.registry.npmjs.org/eslint-plugin-mdx/1.5.5_eslint@6.4.0+react@16.9.0/node_modules/eslint-plugin-mdx/lib/es/rules/remark.js:35:44)
at listeners.(anonymous function).forEach.listener (/home/cdfa/Projects/react-turn-reveal/node_modules/.registry.npmjs.org/eslint/6.4.0/node_modules/eslint/lib/linter/safe-emitter.js:45:58)
at Array.forEach (<anonymous>)
at Object.emit (/home/cdfa/Projects/react-turn-reveal/node_modules/.registry.npmjs.org/eslint/6.4.0/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
at NodeEventGenerator.applySelector (/home/cdfa/Projects/react-turn-reveal/node_modules/.registry.npmjs.org/eslint/6.4.0/node_modules/eslint/lib/linter/node-event-generator.js:253:26)
at NodeEventGenerator.applySelectors (/home/cdfa/Projects/react-turn-reveal/node_modules/.registry.npmjs.org/eslint/6.4.0/node_modules/eslint/lib/linter/node-event-generator.js:282:22)
at NodeEventGenerator.enterNode (/home/cdfa/Projects/react-turn-reveal/node_modules/.registry.npmjs.org/eslint/6.4.0/node_modules/eslint/lib/linter/node-event-generator.js:296:14)
at CodePathAnalyzer.enterNode (/home/cdfa/Projects/react-turn-reveal/node_modules/.registry.npmjs.org/eslint/6.4.0/node_modules/eslint/lib/linter/code-path-analysis/code-path-analyzer.js:646:23)
@JounQin
Copy link
Member

JounQin commented Sep 24, 2019

Async plugin is not supported by Eslint now, it is an known issue, but we can only wait for Eslint support.

Reference: eslint/eslint#3565

@JounQin JounQin added good first issue 👋 This may be a great place to get started! help wanted 🙏 This could use your insight or help labels Sep 24, 2019
@JounQin JounQin added this to the 2.0 milestone Sep 24, 2019
@JounQin JounQin self-assigned this Sep 24, 2019
@JounQin JounQin added the external known issue from external, can't do much by ourselves label Sep 24, 2019
@JounQin
Copy link
Member

JounQin commented Sep 24, 2019

Welcome to PR to add a notice about this in README, or just wait for the official support of async lint rules.

Feel free to reopen it if I'm incorrect.

@JounQin JounQin closed this as completed Sep 24, 2019
@JounQin JounQin pinned this issue Feb 9, 2020
@JounQin JounQin unpinned this issue Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external known issue from external, can't do much by ourselves good first issue 👋 This may be a great place to get started! help wanted 🙏 This could use your insight or help
Development

No branches or pull requests

2 participants