Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename in javascript does not work when mdx.experimentalLanguageServer is enabled #327

Closed
4 tasks done
ambarvm opened this issue Jun 22, 2023 · 2 comments
Closed
4 tasks done

Rename in javascript does not work when mdx.experimentalLanguageServer is enabled #327

ambarvm opened this issue Jun 22, 2023 · 2 comments
Labels
🗄 area/interface This affects the public interface 🤷 no/invalid This cannot be acted upon 👎 phase/no Post cannot or will not be acted on 🐛 type/bug This is a problem

Comments

@ambarvm
Copy link

ambarvm commented Jun 22, 2023

Initial checklist

Affected packages and versions

unifiedjs.vscode-mdx v1.3.0

Link to runnable example

No response

Steps to reproduce

  1. Enable mdx.experimentalLanguageServer
"mdx.experimentalLanguageServer": true
  1. Open a project in vscode containing both javascript and mdx files
  2. Open a javascript file and right click a variable. Click "Rename Symbol".

Expected behavior

An input box should appear to allow the variable rename operation.

Actual behavior

A tooltip appears saying "The element can't be renamed."

image

Runtime

Node v18

Package manager

npm v9

OS

macOS

Build and bundle tools

webpack
@remcohaszing
Copy link
Member

I just enabled version 1.5.0 of the VS Code extension. The implementation got a complete rewrite. This issue should be resolved. Please report a new issue if this problem still persists.

@remcohaszing remcohaszing closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2023
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@remcohaszing remcohaszing added 🐛 type/bug This is a problem 🤷 no/invalid This cannot be acted upon 🗄 area/interface This affects the public interface labels Nov 9, 2023
@github-actions github-actions bot added the 👎 phase/no Post cannot or will not be acted on label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface 🤷 no/invalid This cannot be acted upon 👎 phase/no Post cannot or will not be acted on 🐛 type/bug This is a problem
Milestone
No milestone
Development

No branches or pull requests
2 participants
@remcohaszing @ambarvm