Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Querys #2

Closed
jeetelongname opened this issue Aug 21, 2021 · 3 comments
Closed

New Querys #2

jeetelongname opened this issue Aug 21, 2021 · 3 comments

Comments

@jeetelongname
Copy link

Hi so I am currently working on tree sitter support for doom emacs and i was wondering if you would accept PR's for new querys or if you would prefer them to be upstreamed to neovim?

as far as I am seeing its just a matter of adding the query to the textobjs.scm and it should work ™️ but I could be very wrong.

Thanks for any input you could have

@meain
Copy link
Owner

meain commented Aug 22, 2021

This is great.

If it is beneficial for both projects, I think it would be better if it is upstreamed to nvim-treesitter/nvim-treesitter-textobjects. I can just pull from there. No point in duplicating the effort.

As for adding new text objects, it is pretty much just adding more items to the textobjs.scm file for each lang. At least that is the case here and from what I can understand the same for the neovim package as well.

If for any case, there is Emacs specific things or they don't wanna add things in(which I highly doubt will be the case) we can always add it in this project.

@meain
Copy link
Owner

meain commented Aug 22, 2021

I am also working on something that will let you use custom queries. Probably not what you will need, but just wanted to point it out.
ref: #1

@jeetelongname
Copy link
Author

I was just trying to even out the coverage of text objects but I have been checking out that PR and it looks really cool! Ill go and upstream them and let you know when they are merged. Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants