From d5cf18a1f54deb322205ad33d2eb579bc587bcc7 Mon Sep 17 00:00:00 2001 From: Lawrence Date: Mon, 10 Nov 2014 17:23:45 +0000 Subject: [PATCH] Abstract nodemailer createTransport Currently createTransport is unnecessarily called upon every time a password request is made. --- app/controllers/users/users.password.server.controller.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/controllers/users/users.password.server.controller.js b/app/controllers/users/users.password.server.controller.js index 1d4ae65e8a..a80f555332 100644 --- a/app/controllers/users/users.password.server.controller.js +++ b/app/controllers/users/users.password.server.controller.js @@ -12,6 +12,8 @@ var _ = require('lodash'), nodemailer = require('nodemailer'), async = require('async'), crypto = require('crypto'); + +var smtpTransport = nodemailer.createTransport(config.mailer.options); /** * Forgot for reset password (forgot POST) @@ -65,7 +67,6 @@ exports.forgot = function(req, res, next) { }, // If valid email, send reset email using service function(emailHTML, user, done) { - var smtpTransport = nodemailer.createTransport(config.mailer.options); var mailOptions = { to: user.email, from: config.mailer.from, @@ -167,7 +168,6 @@ exports.reset = function(req, res, next) { }, // If valid email, send reset email using service function(emailHTML, user, done) { - var smtpTransport = nodemailer.createTransport(config.mailer.options); var mailOptions = { to: user.email, from: config.mailer.from, @@ -242,4 +242,4 @@ exports.changePassword = function(req, res) { message: 'User is not signed in' }); } -}; \ No newline at end of file +};