Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

On small screen devices (width less than 767px), the expanded navbar covers the main page content. #1275

Closed
generalgmt opened this issue Mar 19, 2016 · 8 comments
Assignees
Milestone

Comments

@generalgmt
Copy link

Steps:

  1. Reduce the screen size to 767px orr .
  2. click on the collapsible button to expand the nav bar.
    After this, you will see the expanded nav bar covering the content section as shown in the images bellow:

screen shot 2016-03-19 at 3 21 26 pm

It will be great experience to have an enhancement to the boiler plate that keeps the main page visible as users dropdown the menu instead of covering the main page. This change overall gives a better User Experience.

@generalgmt
Copy link
Author

After adding a position attribute of "relative" here is how it will look like:
screen shot 2016-03-19 at 4 16 54 pm

@ilanbiala
Copy link
Member

@mleanos have you noticed this? @generalgmt we aren't really building a UI framework so this isn't a top priority, but if this fix causes no other issues then I'm fine merging it in.

@lirantal lirantal added this to the 0.5.0 milestone Mar 19, 2016
@lirantal
Copy link
Member

Obviously if this fixes a UI issue we should go for it.

@codydaig codydaig self-assigned this Mar 24, 2016
@d3dc
Copy link

d3dc commented Apr 15, 2016

How is this different from the bootstrap class navbar-static-top ?

Why introduce a new class that overrides position: fixed when the style library already offers a way to do this without an override?

I believe having the nav open over the page is the intended behavior of navbar-fixed-top.

@trendzetter
Copy link
Contributor

trendzetter commented Apr 15, 2016

I think this is interesting, I am having some issues with navigation too and I want to return to as close as possible to the mainstream bootstrap way of things.
btw: I am developing an application that tracks meanjs as upstream and I had to reject the changes from pr #1276 in order to merge and make my application work correctly.
I want to test this tonight

@ilanbiala
Copy link
Member

@trendzetter does navbar-fixed-top fix this issue?

@generalgmt
Copy link
Author

@d3dc, yeah that is exactly what navbar-static-top does. Thanks for pointing that out.

@trendzetter
Copy link
Contributor

trendzetter commented Apr 18, 2016

@ilanbiala I almost forgot about it. it seems to working ok + I just checked if my application works with navbar-static-top and it is compatible. I suggest to remove the relative-header, probably I am not the only one having gui issues as a result.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants