Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Hub only serves the "latest"-image #518

Closed
Husky110 opened this issue Sep 5, 2022 · 8 comments
Closed

Docker Hub only serves the "latest"-image #518

Husky110 opened this issue Sep 5, 2022 · 8 comments
Assignees

Comments

@Husky110
Copy link

Husky110 commented Sep 5, 2022

Describe the feature you'd like
I would like to propose that everytime a new release-tag is made in GitHub it is also released on dockerhub. The current version breaks all videos, so I am not even able to revert to an older version to get my videos running. So the best practice for a new release would be that all releases are beeing uploaded to docker hub whereas the newest one also replaces the "latest" tag, but keeping all the old versions alive and not breaking anything. The very idea of docker is to let the user decide which version to run on...

Describe alternatives you've considered
Not seeing my video beeing unable to load? I don't know what to write here... :)

Additional context
None

@mgogoulos
Copy link
Contributor

Great suggestion, just needs a plan and we can execute it. Can you prepare some instructions for the workflow?

@Husky110
Copy link
Author

Husky110 commented Sep 7, 2022

To be honest - I have no freakin' clue how that stuff works... :D
But out of my head I would suggest the following:

  • Do coding and release a new tag
  • Send an image to dockerhub with the new release-tag
  • update the current "latest"-image to use the new release-tag
  • leave the older tags alone

Maybe you can contact Drakkan at this repo: https://github.com/drakkan/sftpgo he is running and maintaining an SFTP-server and I know from first-hand experience that he answers his tickets. So maybe you guys can link together and help each other out. :)

@mgogoulos
Copy link
Contributor

thanks for the suggestion, i'll let this issue open and will try to find some time to implement

@Adito5393
Copy link
Contributor

Keep in mind the latest DockerHub news: Docker is deleting Open Source organisations. Maybe release the images to the GitHub repository?

@mgogoulos
Copy link
Contributor

Keep in mind the latest DockerHub news: Docker is deleting Open Source organisations. Maybe release the images to the GitHub repository?

Thanks for the interest in this, we have a paid subscription to DockerHub since we started using it - plus of course the issue that arose is now resolved...

@Adito5393
Copy link
Contributor

Great to hear you have a paid subscription. I'd like to contribute by adding GitHub actions for automatically releasing Docker images with version tags. To avoid vendor lock-in with GitHub Actions YAML format, I'll write the build commands in a Bash file instead. This is a common practice with CI/CD tools. I'll ping you again when the PR draft is ready for review.

@mgogoulos
Copy link
Contributor

Hi @Adito5393 , just saw the other PR, looks great! Will try to find some time to test it before I merge it.

And yes, definitely some help is needed. What you suggest is important, please go ahead and create a PR when you have the capacity. And as you probably have seen there's room for good optimizations, eg

  • removing a number of variables (that were introduced mostly to facilitate Django migrations, but serve no other purpose any more)
  • even removing some of the docker compose files, or better using overrides, so that there is not that big number anymore (that makes testing them very hard)
  • suggestions on whether DB and media_files should be defined ona different way
  • even the Dockerfiles for backend/frontend need to be updated
  • Improve Docker and Docker Compose files #709 but I'm sure there are other tickets as well related with Docker

Thanks and regards

@Adito5393
Copy link
Contributor

Hello @mgogoulos,

I have made minimal changes to PR #750. Kindly review and merge it when you have time. The changes are intended to automate an existing docker build and push process, and they should not cause any breaks. Please note that the optimizations you mentioned can be implemented without modifying the .github/workflows/docker-build-push.yml file.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants