New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The config should not be assigned to the window #2

Open

ThijsTyZ opened this issue Apr 16, 2019 · 0 comments

ThijsTyZ commented Apr 16, 2019 •

edited

Loading

Currently the ConfigManager is assigning the configuration to the window
(on line 445: window['config'] = this._parsedConfig;)

I think the ConfigManager should not do that, for multiple reasons:

The information is too easy to find by others
This won't work for NodeJS or some test frameworks, since there is no window object in these environments.
When multiple ConfigManagers are used they overwrite this value
It should not be possible to read and change the content of the config from outside. This could lead to unpredictable behavior.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment