Stripe webhook processing fails with 409 Conflict #4798
Comments
|
Hi @chemicalkosek, thanks for the suggestion! The only thing that doesn't line up in our case is that the frontend (next.js starter) never receives an error from one of its API calls to medusa (completing a cart or otherwise). Here are some example logs from medusa, captured immediately after I submit the order on the frontend. The only error response sent to the frontend is a |
|
It seems to us that during the processing of |
|
To ultimately resolve this, we reset class OrderPlacedSubscriber {
constructor({ eventBusService, cartService, orderService, orderRepository }) {
this.cartService = cartService
this.orderService = orderService
this.orderRepository = orderRepository
eventBusService.subscribe("order.placed", this.handleOrderPlaced, { subscriberId: "order-capture-fulfill" })
}
handleOrderPlaced = async (data) => {
const order = await this.orderService.retrieve(data.id, { relations: ["items"] })
// auto-capture payment
if (order.payment_status !== "captured") {
await this.orderService.capturePayment(order.id)
}
// ... more processingAfter some digging, it makes more sense to me why the 409 Conflict exists and is ultimately, the right thing to do. The Stripe webhook will get re-sent eventually, and then it does succeed, but that is no longer relevant with this approach. |
|
Just wanted to add to this to potentially help in debugging, from testing we have determined that the stripe only conflicts and fails when the its a guest user processing the transaction - anyone logged in we can't replicate the 409 conflicts from stripe webhook |
|
409 Conflict happens regardless of whether I am registered and logged in or not. |
|
Listen to "order.placed" should not be enough, orders are not saved into DB when hook receives 409, so the "order.placed" event will never occur... am i wrong? |
Bug report
Describe the bug
Processing for the
payment_intent.succeededStripe webhook event fails with409 Conflict.System information
Medusa version (including plugins):
1.14.0, medusa-payment-stripe6.0.2Node.js version:
v18.10.0Database: Postgres 14
Operating system: Linux
Browser (if relevant):
Steps to reproduce the behavior
payment_intent.amount_capturable_updated,payment_intent.payment_failed, andpayment_intent.succeeded, API version2022-11-15capture: trueundermedusa-payment-stripeoptions inmedusa-config.jsnextjs-starter-medusafrontend and run through checkout flow with item(s) in cart.Expected behavior
payment_intent.succeededprocessing is successful, order is marked as "Paid" in Medusa, Stripe receives200 OKresponse.Screenshots
Here are some relevant logs we are seeing when running through this flow.
medusa
postgres
Code snippets
Relevant processing paths are here,
https://github.com/medusajs/medusa/blob/v1.14.0/packages/medusa-payment-stripe/src/api/utils/utils.ts#L69
https://github.com/medusajs/medusa/blob/v1.14.0/packages/medusa-payment-stripe/src/api/utils/utils.ts#L134-L145
Based on some simple debugging (adding logger output to the stripe plugin), I think the failure occurs here: https://github.com/medusajs/medusa/blob/v1.14.0/packages/medusa-payment-stripe/src/api/utils/utils.ts#L250-L252
Then, on the second call to the webhook endpoint (see additional context below), the order has already been created from the cart, and the entire code block after the check for an existing order doesn't execute, returning a
200 OKto stripe: https://github.com/medusajs/medusa/blob/v1.14.0/packages/medusa-payment-stripe/src/api/utils/utils.ts#L214-L219Additional context
If the webhook event is resent (after this initial failure and
409 Conflictresponse), either manually or automatically by Stripe, the processing succeeds, and returns a200 OKto stripe, marking the order as "Paid" in medusa. This leads me to believe that there may be a race condition occurring, between stripe and the API calls the nextjs starter is making.It may also be worth noting that the only call to the
orderServicethat doesn't include.withTransaction()is here: https://github.com/medusajs/medusa/blob/v1.14.0/packages/medusa-payment-stripe/src/api/utils/utils.ts#L215, but I added that into a local version of themedusa-payment-stripeplugin and tested that, with no change in behavior.The text was updated successfully, but these errors were encountered: