Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically downloading Node #18

Closed
medz opened this issue Sep 8, 2022 · 4 comments
Closed

Automatically downloading Node #18

medz opened this issue Sep 8, 2022 · 4 comments

Comments

@medz
Copy link
Owner

medz commented Sep 8, 2022

RobertCraigie/prisma-client-py#454

There is a good proposal in Prisma for python. At the same time, it can reduce unnecessary repetitive development work and let us focus more on generator and runtime development.

@jacobaraujo7
Copy link
Contributor

Can't we download the node to solve the problem of downloading the binary and then delete it?

@medz
Copy link
Owner Author

medz commented Sep 9, 2022

Can't we download the node to solve the problem of downloading the binary and then delete it?

The idea in prisma-cli-py is that the Prisma command part uses Prisma official Prisma CLI (developed with Node.js), while we focus on Prisma runtime and client development.

This question is just for discussion, because Prisma for Dart CLI works well (although there are several commands that are not developed).

If we introduce Prisma CLI (Node.js), this will definitely ease our maintenance efforts.

@utamori
Copy link

utamori commented Sep 20, 2022

First of all, thanks for this great project

Implementing all of Prisma's commands seems like a daunting task
It is also hard to adapt to new commands.

It just doesn't seem sustainable.

The idea in prisma-cli-py is that the Prisma command part uses Prisma official Prisma CLI (developed with Node.js), while we focus on Prisma runtime and client development.

I completely agree with that idea.

@medz
Copy link
Owner Author

medz commented Sep 23, 2022

Maybe we can create a draft to experiment with it, I believe it's far better to keep the toolchain intact than maintaining the CLI ourselves.

But from another point of view, as a Dart or Flutter developer, many people may not want to silently install a Node in his/her computer (that is, it is not a global one, but a real project path to Prisma for Dart).

@medz medz added the invalid label Feb 17, 2023
@medz medz closed this as completed Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants