This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
fix(store): normalize pattern ids across platforms #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheReincarnator
suggested changes
Mar 8, 2018
There was a problem hiding this comment.
.@marionebl says split/join is not that wrong, and he convinced me.
The original paths are OS-specific, then joined OS-specific, and then we should split them OS-specific, and join again using the '/' character, as the join is a pattern ID, not a path.
Additionally, the RegEx construction is not perfectly correct. The string is a regex, but PathUtils.sep is not.
So we should split(PathUtils.sep) and join('/').
faselbaum
force-pushed
the
fix/react-analyzer-windows-paths
branch
from
298654a
to
22dccdd
Compare
|
@TheReincarnator done |
TheReincarnator
approved these changes
Mar 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes pattern detection on windows