This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
feat: update styling of pattern pane #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilmx
changed the title
marionebl
reviewed
May 29, 2018
src/components/input/index.tsx
Outdated
| const StyledIcon = styled(Icon)` | ||
| position: absolute; | ||
| left: 0; | ||
| top: ${getSpace(SpaceSize.M) - 1}px; // fix to propertly align icon |
There was a problem hiding this comment.
Please use top: 50%; transform: translateY(-50%) here
| margin-left: -${getSpace(SpaceSize.L)}px; | ||
| margin-right: -${getSpace(SpaceSize.L)}px; | ||
| padding: 0 ${getSpace(SpaceSize.M)}px; | ||
| overflow-y: scroll; |
There was a problem hiding this comment.
Use auto here to avoid useless scrollbars
marionebl
approved these changes
May 30, 2018
markusoelhafen
pushed a commit
that referenced
this pull request
Jun 12, 2018
* fix: replace pattern icon * feat: move pattern pane to left sidebar * feat: enable resizing for pattern pane * feat: apply new pattern list item styling * fixup! resolve merge conflict * feat: apply new pattern label styling * feat: apply new pattern search styling * fix: rename input to search * fixup! rename input properly in other files * fix: restore page title editing * fix: replace overflow scroll with auto
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be squashed into "feat: update styling of pattern pane"