-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AI-powered search tutorial #3056
base: main
Are you sure you want to change the base?
Conversation
How to see the preview of this PR?Go to this URL: https://website-git-deploy-preview-mei-16-meili.vercel.app/docs/branch:3039-improve-ai-tutorial Credentials to access the page are in the company's password manager as "Docs deploy preview". |
``` | ||
|
||
This template starts by giving the general context of the document: `An object used in a kitchen`. Then you give it the information specific to each document. `doc` is your document, and you can access any of its attributes using dot notation. `name` is an attribute in your document, with values such as `wooden spoon` or `rolling pin`. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should specify here that if a field appears in a document template, then it should exist in all the documents of the index?
|
||
```json | ||
{ | ||
"kitchenware-openai": {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that you chose a name that is not directly openai
so that users don't confuse the embedder name with the source
. I'm not sure I like prefixing the index name though. Ideally we'd find something else 🤔. If we don't, we can leave it as-is
@@ -91,16 +173,21 @@ curl \ | |||
--data-binary '{ | |||
"q": "kitchen utensils made of wood", | |||
"hybrid": { | |||
"embedder": "openai", | |||
"semanticRatio": 0.7 | |||
"embedder": "openai" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"embedder": "openai" | |
"embedder": "kitchenware-openai" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few inline comments, but otherwise looks good to me :-)
Closes #3039