Ensure nested field support #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alallema
requested review from
bidoubiwa and
brunoocasali
and removed request for
bidoubiwa
alallema
added
the
maintenance
brunoocasali
reviewed
May 2, 2022
|
|
||
| private TestData<Movie> testData; | ||
|
|
||
| final class Results { |
There was a problem hiding this comment.
This class already exist in other places right?
There was a problem hiding this comment.
Yes, in the SearchTest file.
|
|
||
| @AfterAll | ||
| static void cleanMeiliSearch() { | ||
| cleanup(); |
There was a problem hiding this comment.
Hey, look here: https://docs.cypress.io/guides/references/best-practices#Using-after-or-afterEach-hooks
It is not so good to teardown your test setup after the execution :D
There was a problem hiding this comment.
I don't understand, do you mean I have to do it afterEach instead or not clean at all?
Because I like to clean after each test file in order to have independent test no?
alallema
added
enhancement
bors bot
added a commit
that referenced
this pull request
May 9, 2022
365: Changes related to the next Meilisearch release (v0.27.0) r=curquiza a=meili-bot Related to this issue: meilisearch/integration-guides#190 This PR: - gathers the changes related to the next Meilisearch release (v0.27.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases). - might eventually contain test failures until the Meilisearch v0.27.0 is out.⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.27.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._ Done: - #366 - #370 - #374 - #375 - #377 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Amélie <alallema@users.noreply.github.com> Co-authored-by: alallema <amelie@meilisearch.com>
bors bot
added a commit
that referenced
this pull request
May 9, 2022
380: Update version for the next release (v0.7.2) r=curquiza a=alallema This version makes this package compatible with MeiliSearch v0.27.0🎉 Check out the changelog of [MeiliSearch v0.27.0](https://github.com/meilisearch/MeiliSearch/releases/tag/v0.27.0) for more information about the changes. ## 🚀 Enhancements - Ensure nested field support #374 `@alallema` - Add new search parameters `highlightPreTag`, `highlightPostTag` and `cropMarker` #375 `@alallema` Co-authored-by: alallema <amelie@meilisearch.com> Co-authored-by: Amélie <alallema@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests on nested fields to ensure it is still maintained in Meilisearch.