Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype: Separators settings api #1556

Closed
bidoubiwa opened this issue Aug 3, 2023 · 1 comment · Fixed by #1563
Closed

Prototype: Separators settings api #1556

bidoubiwa opened this issue Aug 3, 2023 · 1 comment · Fixed by #1563
Assignees
Labels
enhancement New feature or request

Comments

@bidoubiwa
Copy link
Contributor

Description
Two new settings named separatorTokens and nonSeparatorTokens are being introduced as a prototype in meilisearch. We would like to create a prototype version of meilisearch-js implementing the required changes to be able to try out the new settings.

Following this specification, we need to add:

  • Two GET routes that fetches the settings
  • Two PUT routes that updates the settings
  • Two Delete routes that resets the settings
  • Add the new settings in the Settings types
  • Add tests

Basic example

client.index('x').getSeparatorTokens()
client.index('x').getNonSeparatorTokens()
client.index('x').updateSeparatorTokens(["|", "/", "&sep"])
client.index('x').updateNonSeparatorTokens(["@", "#"])
client.index('x').resetSeparatorTokens()
client.index('x').resetNonSeparatorTokens()
@bidoubiwa bidoubiwa added the enhancement New feature or request label Aug 3, 2023
@curquiza
Copy link
Member

Closed by #1573

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants