Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on Vitest recommended ESLint rules #1745

Closed
flevi29 opened this issue Oct 11, 2024 · 1 comment · Fixed by #1748
Closed

Turn on Vitest recommended ESLint rules #1745

flevi29 opened this issue Oct 11, 2024 · 1 comment · Fixed by #1748
Labels
maintenance Issue about maintenance (CI, tests, refacto...)

Comments

@flevi29
Copy link
Collaborator

flevi29 commented Oct 11, 2024

rules: {
...vitest.configs.recommended.rules,
// @TODO: Remove all of these rules and adapt code!
"vitest/expect-expect": "off",
"vitest/valid-title": "off",
"vitest/valid-expect": "off",
},

According to the @TODO, remove all of the rule overrides and adapt code.

@flevi29 flevi29 added the maintenance Issue about maintenance (CI, tests, refacto...) label Oct 11, 2024
@Barabasbalazs
Copy link
Contributor

Threw something together here: #1748

@meili-bors meili-bors bot closed this as completed in c49c0b5 Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue about maintenance (CI, tests, refacto...)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@Barabasbalazs @flevi29 and others