Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for chemicals as camos on framed blocks #8209

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

XFactHD
Copy link
Contributor

@XFactHD XFactHD commented Aug 21, 2024

Changes proposed in this pull request:

Add FramedBlocks integration to support chemicals as camos on framed blocks.

A few noteworthy points:

  • I've left a TODO about light emission as this is currently not exposed by the chemical itself and instead only available at the IChemicalConstant level
  • I've left a TODO about MapColor as the chemicals of course don't have any, considering they are never placed in-world. Returning null will fall back to the framed block's map color. It might be interesting to store a mapping of chemical->map color in the integration which is automatically computed from the chemical's color representation Addressed
  • Adding and removing a chemical camo currently consumes and returns respectively the same 1000mB as the fluid camo does
  • Stepping/falling on, hitting and breaking a block with a chemical camo uses the stone sound type for now. Fluid camos have the same issue and I have not found a satisfactory solution for this yet Addressed

Copy link
Member

@pupnewfster pupnewfster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! I will try to test it tomorrow, and assuming I don't run into any bugs, and that it doesn't accidentally introduce a hard dep on framed blocks I will go ahead and merge it afterwards.

@pupnewfster pupnewfster merged commit a87b00c into mekanism:1.21.x Aug 22, 2024
3 checks passed
@XFactHD XFactHD deleted the framedblocks_chemical_camo branch August 22, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants