Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor setting and clearing badge text into a helper method(s) exposing only valid states #463

Open
melink14 opened this issue May 6, 2021 · 0 comments
Open

Refactor setting and clearing badge text into a helper method(s) exposing only valid states #463

melink14 opened this issue May 6, 2021 · 0 comments
Labels
Code health Issues which if fixed would improve the health of the project (as opposed to new features/bugs)

Comments

@melink14
Copy link
Owner

melink14 commented May 6, 2021

rikaikun only allows nothing and 'On' but setBadgeText allows arbitrary text which makes it harder to understand the goals of the author down the line. (Is empty string accidental or on purpose etc)

This came up in #462 since it added another location where we set badge text.
@melink14 melink14 added the Code health Issues which if fixed would improve the health of the project (as opposed to new features/bugs) label May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code health Issues which if fixed would improve the health of the project (as opposed to new features/bugs)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@melink14