Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression/Windows] Launching MelonDS with the fullscreen parameter doesn't do anything #2083

Closed
Immersion95 opened this issue Jun 28, 2024 · 7 comments

Comments

@Immersion95
Copy link

Immersion95 commented Jun 28, 2024

Launching MelonDS with the fullscreen parameter (-f or --fullscreen) doesn't do anything.

It remembers the last state (fullscreen or windowed). If it's fullscreen, the bar is still here. You have to change to windowed then to fullscreen.

Last working commit is 8e9b88d

@Blackbird88
Copy link

Blackbird88 commented Jul 14, 2024

Also on Windows, but for me it doesn't work at all, melonDS just stays in its default small window state

@Immersion95
Copy link
Author

Is there any news on this matter or a workaround ?

@Immersion95 Immersion95 changed the title [Regression/Windows] Launching MelonDS with the fullscreen parameter doesn't hide the menu bar [Regression/Windows] Launching MelonDS with the fullscreen parameter doesn't do anything Oct 6, 2024
@Immersion95
Copy link
Author

Edited the first post and title. The fullscreen parameter doesn't work at all.

@RSDuck RSDuck closed this as completed in aa443c8 Oct 6, 2024
@RSDuck
Copy link
Member

RSDuck commented Oct 6, 2024

looks like it was forgotten to be readded during refactoring

@Blackbird88
Copy link

Blackbird88 commented Oct 6, 2024

Works for me, unrelated to the issue, but it would be nice if fullscreen was temporary. Right now exiting melonDS makes it FS on next launch, kinda defeating the purpose.

@RSDuck
Copy link
Member

RSDuck commented Oct 6, 2024

that should not be the case, we don't store the fullstate state anywhere. Either QT or the OS seems to be storing this. I'll try to override this.

@RSDuck
Copy link
Member

RSDuck commented Oct 6, 2024

it actually was our fault. Well I fixed it now though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants