Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAMs problems in Refactor branch #68

Open
jalabort opened this issue Aug 13, 2015 · 1 comment
Open

AAMs problems in Refactor branch #68

jalabort opened this issue Aug 13, 2015 · 1 comment
Labels

Comments

@jalabort
Copy link
Member

On the refactor branch #67 all AAM fitting algorithms using the LucasKanadeStandardInterface are slightly wrong. At the moment they are performing additive, instead of compositional updates!

We have to options to amend this:

  1. Re-implement the solve_all_map and solve_all_ml methods on the previous interface so that they effectively use the "parameter Jacobian" Jp. This might make the functions _solve_all_map and _solve_all_ml quite complicated...
  2. Go back to using the VComposable interface. This would mean that PDMs need to support the previous interface and that ModelDrivenTransforms and PDMs need to handle priors internally.
@jalabort jalabort added the bug label Aug 13, 2015
@patricksnape
Copy link
Contributor

In Option 1 - how complicated? I think I prefer option 1. Even if there are basically two subfunctions that do either additive or compositional updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants