Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pre-commit lint hook for staged files. #1878

Closed
sidharthv96 opened this issue Feb 2, 2021 · 1 comment · Fixed by #2522
Closed

Add a pre-commit lint hook for staged files. #1878

sidharthv96 opened this issue Feb 2, 2021 · 1 comment · Fixed by #2522
Labels
Status: Triage Needs to be verified, categorized, etc Type: Enhancement New feature or request

Comments

@sidharthv96
Copy link
Member

Is your feature request related to a problem? Please describe.
This will ensure that the developer does not have to run lint manually

Describe the solution you'd like
Use lint-staged along with husky to lint all modified files before each commit

Describe alternatives you've considered
Manual linting / Save automatically via editor. But both are not standard.

Additional context
This has already been implemented in mermaid-live-editor

@sidharthv96 sidharthv96 added Type: Enhancement New feature or request Status: Triage Needs to be verified, categorized, etc labels Feb 2, 2021
@harshilparmar
Copy link
Contributor

@sidharthv96 I would like to work on this issue.

@Yash-Singh1 Yash-Singh1 mentioned this issue Nov 2, 2021
43 tasks
@knsv knsv closed this as completed in #2522 Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants