From 47fc8f7cb8f9ad191a4dae5d5908a2715a6acea5 Mon Sep 17 00:00:00 2001 From: Nicolas Mahe Date: Mon, 8 Jul 2019 15:20:01 +0700 Subject: [PATCH 1/3] Improve root commands --- package.json | 8 ++++---- src/docker-command.ts | 2 +- src/marketplace-command.ts | 6 +++--- src/root-command.ts | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/package.json b/package.json index 6bc0214..ab9cd1f 100644 --- a/package.json +++ b/package.json @@ -84,16 +84,16 @@ ], "topics": { "service": { - "description": "Manage MESG Services" + "description": "Manage services" }, "daemon": { - "description": "Manage MESG Engine" + "description": "Manage the Engine" }, "marketplace": { - "description": "Let you interact with the MESG Marketplace" + "description": "Interact with the Marketplace" }, "account": { - "description": "Manage your MESG Accounts" + "description": "Manage accounts" } } }, diff --git a/src/docker-command.ts b/src/docker-command.ts index 3086ad1..fc4d5ba 100644 --- a/src/docker-command.ts +++ b/src/docker-command.ts @@ -34,7 +34,7 @@ export default abstract class extends Command { static flags = { ...Command.flags, name: flags.string({ - description: 'Name of the service running the engine', + description: 'Name of the docker service running the engine', required: true, default: 'engine' }), diff --git a/src/marketplace-command.ts b/src/marketplace-command.ts index 71fa2c1..a056210 100644 --- a/src/marketplace-command.ts +++ b/src/marketplace-command.ts @@ -28,7 +28,7 @@ export default abstract class MarketplaceCommand extends Command { }), passphrase: flags.string({ char: 'p', - description: 'Passphrase to unlock your account' + description: 'Passphrase to unlock the account' }) } @@ -65,7 +65,7 @@ export default abstract class MarketplaceCommand extends Command { const {account} = (await prompt({ type: 'list', name: 'account', - message: 'Choose the account to use to publish your service', + message: 'Select the account to use:', choices: addresses })) as { account: string } return account @@ -76,6 +76,6 @@ export default abstract class MarketplaceCommand extends Command { if (flags.passphrase) { return flags.passphrase } - return cli.prompt('Type your passphrase', {type: 'hide'}) + return cli.prompt('Type the passphrase of the account', {type: 'hide'}) } } diff --git a/src/root-command.ts b/src/root-command.ts index 391de23..8d006a7 100644 --- a/src/root-command.ts +++ b/src/root-command.ts @@ -9,7 +9,7 @@ import {format, inspect} from 'util' export default abstract class extends Command { static flags = { help: flags.help({char: 'h'}), - quiet: flags.boolean({char: 'q', description: 'Display only important information'}), + quiet: flags.boolean({char: 'q', description: 'Display only result. No loader.'}), silent: flags.boolean({hidden: true}), } From 4e301b274158a9fd771b76220371c2ab092f981d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicolas=20Mah=C3=A9?= Date: Mon, 8 Jul 2019 16:51:12 +0700 Subject: [PATCH 2/3] Apply suggestions from code review Co-Authored-By: krhubert --- src/marketplace-command.ts | 2 +- src/root-command.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/marketplace-command.ts b/src/marketplace-command.ts index a056210..1ac3749 100644 --- a/src/marketplace-command.ts +++ b/src/marketplace-command.ts @@ -76,6 +76,6 @@ export default abstract class MarketplaceCommand extends Command { if (flags.passphrase) { return flags.passphrase } - return cli.prompt('Type the passphrase of the account', {type: 'hide'}) + return cli.prompt('Type the passphrase', {type: 'hide'}) } } diff --git a/src/root-command.ts b/src/root-command.ts index 8d006a7..437af62 100644 --- a/src/root-command.ts +++ b/src/root-command.ts @@ -9,7 +9,7 @@ import {format, inspect} from 'util' export default abstract class extends Command { static flags = { help: flags.help({char: 'h'}), - quiet: flags.boolean({char: 'q', description: 'Display only result. No loader.'}), + quiet: flags.boolean({char: 'q', description: 'Display only result without spinner'}), silent: flags.boolean({hidden: true}), } From 3e744517f097a565766ee7bb8ba3ce0967ccef85 Mon Sep 17 00:00:00 2001 From: Anthony Date: Mon, 8 Jul 2019 18:17:24 +0700 Subject: [PATCH 3/3] Update src/root-command.ts --- src/root-command.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/root-command.ts b/src/root-command.ts index 437af62..0d8c13a 100644 --- a/src/root-command.ts +++ b/src/root-command.ts @@ -9,7 +9,7 @@ import {format, inspect} from 'util' export default abstract class extends Command { static flags = { help: flags.help({char: 'h'}), - quiet: flags.boolean({char: 'q', description: 'Display only result without spinner'}), + quiet: flags.boolean({char: 'q', description: 'Display only essential information'}), silent: flags.boolean({hidden: true}), }