Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests when running from the command line on a fresh setup #62

Open
dangg opened this issue Aug 7, 2019 · 1 comment
Open

Comments

@dangg
Copy link
Contributor

dangg commented Aug 7, 2019

Situation:
According to the documentation at https://github.com/messagebird/java-rest-api/blob/master/README.md running the command

mvn test -Ptest -DmessageBirdAccessKey=[your access key] -DmessageBirdMSISDN=[your phone]

should run the tests, however the tests are skipped

The issue seems to come from the configuration under the default profile


default

false

Before changing this we need to ensure we don't break something else (such as builds)

@rvt
Copy link
Contributor

rvt commented May 8, 2020

Perhaps it makes sense to split the tests that require DmessageBirdAccessKey and DmessageBirdMSISDN and move these to integration tests. While leaving the pure unit tests in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants