From bbcd4ddce7aa4d3617db096b78b6f84361dab742 Mon Sep 17 00:00:00 2001 From: Huy Mai Date: Wed, 11 Sep 2024 11:25:47 +0000 Subject: [PATCH] Pin ginkgo cli to test/go.mod ginkgo package Signed-off-by: Huy Mai --- Makefile | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 11cbcbe27d..44b4208260 100644 --- a/Makefile +++ b/Makefile @@ -24,7 +24,6 @@ CRD_OPTIONS ?= "crd:allowDangerousTypes=true,crdVersions=v1" KUSTOMIZE = tools/bin/kustomize CONTROLLER_GEN = tools/bin/controller-gen GINKGO = tools/bin/ginkgo -GINKGO_VER = v2.17.1 DEPLOY_CLI = tools/bin/deploy-cli # See pkg/version.go for details @@ -288,8 +287,8 @@ tools: go build -o bin/make-bm-worker cmd/make-bm-worker/main.go go build -o bin/make-virt-host cmd/make-virt-host/main.go -$(GINKGO): ## Install ginkgo in tools/bin - GOBIN=$(abspath tools/bin) go install github.com/onsi/ginkgo/v2/ginkgo@$(GINKGO_VER) +$(GINKGO): ## Install ginkgo in tools/bin. Take ginkgo version from `test/go.mod`. + cd test; GOBIN=$(abspath tools/bin) go install github.com/onsi/ginkgo/v2/ginkgo ## -------------------------------------- ## Tilt / Kind