Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle batches of wallet approval #19

Closed
lorisleiva opened this issue Mar 23, 2022 · 1 comment
Closed

Handle batches of wallet approval #19

lorisleiva opened this issue Mar 23, 2022 · 1 comment
Assignees

Comments

@lorisleiva
Copy link
Contributor

Find a way to improve both the UX and the DevX when signing multiple transactions and messages that simply can't be bulk signed using signAllTransactions.

For example, when minting an NFT using Bundlr, it will require 5 approvals:

  • One for signing the fund transaction of the first upload (the image)
  • One for signing a message allowing Bundlr to upload it.
  • One for signing the fund transaction of the second upload (the metadata referencing the first upload).
  • One for signing a message allowing Bundlr to upload it.
  • One for signing the transaction that will create the NFT.

(Note that the two funding transactions could be merged into one)

In these situations, the user will inevitably end up having to click "approve" multiple times. A better UX would be to provide them with a modal like the one below where they can see what they are going to approve and why.

image

The SDK should probably facilitate that for the developers by providing an abstraction layer on top of "batches of approval" Something that would accept an Array<() => Promise<T>> and keep track of which ones were triggered.

Nothing set in stone, we'd need to discuss in more detail how this would look like concretely by gathering more use cases.

@lorisleiva lorisleiva self-assigned this Apr 6, 2022
@lorisleiva
Copy link
Contributor Author

Done with Plans. Needs documenting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant