feat: add instant sale action #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaxozhu
previously approved these changes
Nov 9, 2021
kurpav
changed the title
ViacheslavMylostyvyi
previously approved these changes
Nov 10, 2021
b2kdaman
previously approved these changes
Nov 10, 2021
kurpav
dismissed stale reviews from b2kdaman and ViacheslavMylostyvyi
via
d131b5a
|
Please add unit tests |
zaxozhu
approved these changes
Nov 11, 2021
|
@aheckmann I'd be glad to write unit tests, but the question is if it makes sense. I propose to add integration tests after we implement auction create flow. |
|
🎉 This PR is included in version 4.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.