Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add send token action #81

Merged
merged 2 commits into from
Dec 1, 2021
Merged

feat: add send token action #81

merged 2 commits into from
Dec 1, 2021

Conversation

kurpav
Copy link
Contributor

@kurpav kurpav commented Nov 30, 2021

Adds an action to allow sending tokens between wallets

// destination wallet address
destination: PublicKey;
mint: PublicKey;
amount: number | u64;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about having a BN here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u64 extends BN
And to be honest I don't have any idea how can we send more than 1 token from a token account with NFT

zaxozhu
zaxozhu previously approved these changes Nov 30, 2021
src/actions/sendToken.ts Outdated Show resolved Hide resolved
@b2kdaman b2kdaman self-requested a review November 30, 2021 21:26
@kurpav kurpav merged commit b5f9d7c into main Dec 1, 2021
@kurpav kurpav deleted the feature/send-token-action branch December 1, 2021 08:45
@zaxozhu
Copy link
Contributor

zaxozhu commented Dec 1, 2021

🎉 This PR is included in version 4.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants