Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expire Sink data queues by default #36

Closed
phijor opened this issue Jun 1, 2021 · 1 comment
Closed

Expire Sink data queues by default #36

phijor opened this issue Jun 1, 2021 · 1 comment
Assignees
@phijor
Labels
enhancement New feature or request

Comments

@phijor
Copy link
Contributor

phijor commented Jun 1, 2021

Sink data queues should have a default of x-expires = 10min.

This way, under normal circumstances, every client has enough time to attach a consumer. Otherwise (if the sink crashed between subscribing and consuming), the queue will be deleted.o

Note: we should make sure that the default value is long enough to support clients with many metrics, as it might take so time to successfully declare all their bindings.

Related to #35.
@phijor phijor added the enhancement New feature or request label Jun 1, 2021
@phijor phijor self-assigned this Jun 1, 2021
@phijor phijor linked a pull request Jun 2, 2021 that will close this issue
Automatically delete unused queues after a while #38
Closed
@phijor
Copy link
Contributor Author

phijor commented Jun 9, 2021

Closed via #38.

@phijor phijor closed this as completed Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phijor phijor

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Automatically delete unused queues after a while metricq/metricq-manager
1 participant
@phijor