Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider declaring queues as "auto-delete" for transient sinks #67

Closed
phijor opened this issue Feb 2, 2021 · 3 comments
Closed

Consider declaring queues as "auto-delete" for transient sinks #67

phijor opened this issue Feb 2, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@phijor
Copy link
Contributor

phijor commented Feb 2, 2021

If a Sink dies between subscribing and starting to consume metrics, its data queue will not get deleted and starts collecting metric data that is never consumed.

Consider adding an auto-delete to the queue (or something similar) so that this does not happen. At least for Sinks that are short lived are not expected to reuse their data queue after a reconnect.

@bmario
Copy link
Member

bmario commented Feb 4, 2021

The queues are already declared as auto-delete, but that doesn't help.

Auto-delete (queue that has had at least one consumer is deleted when last consumer unsubscribed)

What we need is a queue-TTL.

@phijor
Copy link
Contributor Author

phijor commented Jun 3, 2021

We decided to have the manager use a queue TTL by default when declaring Sink data queues.

This is being implemented in metricq/metricq-manager#38.

@phijor
Copy link
Contributor Author

phijor commented Jun 9, 2021

Closed via #38.

@phijor phijor closed this as completed Jun 9, 2021
@bmario bmario added enhancement New feature or request and removed feature request labels Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants