Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans for replaygain scanning support? #36

Open
koiuo opened this issue Sep 20, 2018 · 2 comments
Open

Any plans for replaygain scanning support? #36

koiuo opened this issue Sep 20, 2018 · 2 comments

Comments

@koiuo
Copy link

koiuo commented Sep 20, 2018

Hi. I found this project via search and it looks amazing. I haven't yet had a chance to look at it in detail, so I'm sorry if missed obvious answers to my questions.

Do you think it's worth implementing a feature that repeats metaflac --add-replay-gain behavior?
Does this feature even belong here?

Or should I instead use this project to decode flac to pcm and use something else to determine loudness? Do you happen to know go libraries that would do that?

Thanks

@wsc1
Copy link

wsc1 commented Sep 20, 2018

I don't know of Go libraries that currently support replay-gain, but there is one related project zikichombo which would be either a good place to house replay-gain or a good basis on which to implement it for flac or other codecs. The project is new, in alpha, and does not yet have resources to plan releases. So depending on your timeline, production needs, etc, it may or may not help. But it is at least one option to look at.

@mewmew
Copy link
Member

mewmew commented Sep 20, 2018

Hi. I found this project via search and it looks amazing. I haven't yet had a chance to look at it in detail, so I'm sorry if missed obvious answers to my questions.

Hi @edio!

Glad to hear from you and happy to hear that you like the project from a 10,000 feet view. Ask away, and we'll see if we can answer :) Note, we are audio hobbyists, so it may very well be that you have better answers for some questions than we do. In which case, consider yourself invited, both to discussions and also further development (see #33 and #19 if interested).

Do you think it's worth implementing a feature that repeats metaflac --add-replay-gain behavior?
Does this feature even belong here?

There is actually a go-metaflac command which mimics the functionality of metaflac. It currently supports all --list-foo flags, but does not have support for modifying metadata. Re-encoding of metadata is fully implemented. However it should be noted that the re-encoding of audio samples is not yet fully supported. The encoding API was updated with PR #32, and as such, the metaflac command is not yet ported to make use of the new API. This will definitely happen, but implementing support for LPC (#35) is a prerequisite for this.

If you are interested to peek under the hood, feel free to explore the internals of the project, and let us know if you'd be interested in getting involved with coding audio libraries in Go :)

Once #35 is implemented, it would definitely make sense to implement the commands of metaflac just to stress test the API. As such, support for --add-replay-gain would be added.

Happy coding!

Cheers Henry and Robin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants