Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rule): template-accessibility-label-for not recognizing options and interpolated values #812

Merged
merged 2 commits into from
Apr 17, 2019
Merged

fix(rule): template-accessibility-label-for not recognizing options and interpolated values #812

merged 2 commits into from
Apr 17, 2019

Conversation

rafaelss95
Copy link
Collaborator

This:

  • Fixes the JSON schema;
  • Includes all default HTML tags that a label could be used for;
  • Includes all default label attributes that represent the for attribute;
  • Change options description to describe the options;
  • Validate options that are passed correctly;

Fixes #808 #811.

@rafaelss95 rafaelss95 requested review from mgechev and wKoza April 16, 2019 00:55
@mgechev mgechev merged commit 1fb5d8a into mgechev:master Apr 17, 2019
@rafaelss95 rafaelss95 deleted the fix/808 branch April 19, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgechev mgechev mgechev approved these changes

@wKoza wKoza Awaiting requested review from wKoza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

template-accessibility-label-for: not recognizing id/for attributes with interpolated values
2 participants
@rafaelss95 @mgechev