From 7e9410309b045f7ca0fb80ead5ae0030859ca313 Mon Sep 17 00:00:00 2001 From: WilliamKoza Date: Thu, 15 Jun 2017 17:53:37 +0200 Subject: [PATCH] rename rules in documentation --- docs/_data/rules.json | 33 ++++--- .../recursiveAngularExpressionVisitor.js | 4 + .../src/angular/templates/templateParser.js | 86 +++++++++++++------ .../src/importDestructuringSpacingRule.js | 2 +- .../src/noAttributeParameterDecoratorRule.js | 2 +- docs/dist/src/noInputRenameRule.js | 2 +- docs/dist/src/noOutputRenameRule.js | 2 +- docs/dist/src/pipeNamingRule.js | 2 +- docs/dist/src/templateToNgTemplateRule.js | 6 +- docs/dist/src/templatesUsePublicRule.js | 2 +- docs/dist/src/useHostPropertyDecoratorRule.js | 2 +- .../dist/src/useInputPropertyDecoratorRule.js | 2 +- .../src/useOutputPropertyDecoratorRule.js | 2 +- docs/rules/component-selector/index.html | 5 +- .../index.html | 4 +- .../index.html | 4 +- .../index.html | 4 +- .../index.html | 4 +- .../index.html | 4 +- docs/rules/template-to-ng-template/index.html | 12 +++ .../templates-no-negated-async/index.html | 14 +++ .../index.html | 6 +- .../index.html | 4 +- .../index.html | 4 +- .../index.html | 4 +- src/importDestructuringSpacingRule.ts | 2 +- src/noAttributeParameterDecoratorRule.ts | 2 +- src/noInputRenameRule.ts | 2 +- src/noOutputRenameRule.ts | 2 +- src/pipeNamingRule.ts | 2 +- src/templatesNoNegatedAsyncRule.ts | 2 +- src/templatesUsePublicRule.ts | 2 +- src/useHostPropertyDecoratorRule.ts | 2 +- src/useInputPropertyDecoratorRule.ts | 2 +- src/useOutputPropertyDecoratorRule.ts | 2 +- 35 files changed, 152 insertions(+), 84 deletions(-) rename docs/rules/{import-destructing-spacing-rule => import-destructing-spacing}/index.html (73%) rename docs/rules/{no-attribute-parameter-decorator-rule => no-attribute-parameter-decorator}/index.html (71%) rename docs/rules/{no-input-rename-rule => no-input-rename}/index.html (85%) rename docs/rules/{no-output-rename-rule => no-output-rename}/index.html (85%) rename docs/rules/{pipe-naming-rule => pipe-naming}/index.html (93%) create mode 100644 docs/rules/template-to-ng-template/index.html create mode 100644 docs/rules/templates-no-negated-async/index.html rename docs/rules/{templates-use-public-rule => templates-use-public}/index.html (70%) rename docs/rules/{use-host-property-decorator-rule => use-host-property-decorator}/index.html (87%) rename docs/rules/{use-input-property-decorator-rule => use-input-property-decorator}/index.html (88%) rename docs/rules/{use-output-property-decorator-rule => use-output-property-decorator}/index.html (88%) diff --git a/docs/_data/rules.json b/docs/_data/rules.json index 7d9884d5f..2f40eabe4 100644 --- a/docs/_data/rules.json +++ b/docs/_data/rules.json @@ -130,7 +130,7 @@ "typescriptOnly": true }, { - "ruleName": "import-destructing-spacing-rule", + "ruleName": "import-destructing-spacing", "type": "style", "description": "Ensure consistent and tidy imports.", "rationale": "Imports are easier for the reader to look at when they're tidy.", @@ -157,7 +157,7 @@ "typescriptOnly": true }, { - "ruleName": "no-attribute-parameter-decorator-rule", + "ruleName": "no-attribute-parameter-decorator", "type": "maintainability", "description": "Disallow usage of @Attribute decorator", "rationale": "@Attribute is considered bad practice. Use @Input instead.", @@ -175,7 +175,7 @@ "typescriptOnly": true }, { - "ruleName": "no-input-rename-rule", + "ruleName": "no-input-rename", "type": "maintainability", "description": "Disallows renaming directive inputs by providing a string to the decorator.", "descriptionDetails": "See more at https://angular.io/styleguide#!#05-13.", @@ -185,7 +185,7 @@ "typescriptOnly": true }, { - "ruleName": "no-output-rename-rule", + "ruleName": "no-output-rename", "type": "maintainability", "description": "Disallows renaming directive outputs by providing a string to the decorator.", "descriptionDetails": "See more at https://angular.io/styleguide#!#05-13.", @@ -212,7 +212,7 @@ "typescriptOnly": true }, { - "ruleName": "pipe-naming-rule", + "ruleName": "pipe-naming", "type": "style", "description": "Enforce consistent case and prefix for pipes.", "rationale": "Consistent conventions make it easy to quickly identify and reference assets of different types.", @@ -240,7 +240,16 @@ "typescriptOnly": true }, { - "ruleName": "templates-use-public-rule", + "ruleName": "templates-no-negated-async", + "type": "functionality", + "description": "Ensures that strict equality is used when evaluating negations on async pipe outout.", + "rationale": "Async pipe evaluate to `null` before the observable or promise emits, which can lead to layout thrashing as components load. Prefer strict `=== false` checks instead.", + "options": null, + "optionsDescription": "Not configurable.", + "typescriptOnly": true + }, + { + "ruleName": "templates-use-public", "type": "functionality", "description": "Ensure that properties and methods accessed from the template are public.", "rationale": "When Angular compiles the templates, it has to access these properties from outside the class.", @@ -249,16 +258,16 @@ "typescriptOnly": true }, { - "ruleName": "templates-use-public-rule", + "ruleName": "template-to-ng-template", "type": "functionality", - "description": "Ensure that properties and methods accessed from the template are public.", - "rationale": "When Angular compiles the templates, it has to access these propertes from outside the class.", + "description": "Ensure that is used instance of