-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rule.import-blacklist] should allow check tests #732
Comments
Hi @chen3feng, thanks for filling the issue. |
I'd like to take a look at doing this. @chavacava do you think this is satisfied by a global option to include tests? Or should it be an option to only this rule? Or should it be per argument (in the case where a user would want to include tests for package foo, but not package bar? Or something else? |
Some options here... Global
For the entire rule
or allow either a []string (for backwards compatibility) or a []map[string]interface{} and DTRT in either case like so...
the above extends out well if different imports apply a different config....
|
This issue is fixed here: #862. cc @chavacava |
fixed by #862 |
Is your feature request related to a problem? Please describe.
Hi, I' using revive to check my team's project, it's great.
I want to disable an unmaintained and archived package, but it doesn't work:
So I checked the source code and found that:
Describe the solution you'd like
I don't know why this design, but at least it should be configurable.
Thanks!
The text was updated successfully, but these errors were encountered: