Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitely exclude files that does not need to show up in "missing from sdist" #3

Closed
gotcha opened this issue Mar 7, 2013 · 6 comments

Comments

@gotcha
Copy link

gotcha commented Mar 7, 2013

I think my distributions should not hold files like .travis.yml or bootstrap.py even though they are checked in.

This is why I'd like to exclude them explicitly from check-manifest verification.

@mgedmin
Copy link
Owner

mgedmin commented Mar 7, 2013

Good point about .travis.yml. It doesn't make sense in a sdist.

I'm less certain about bootstrap.py (and, presumably, buildout.cfg and similar files). I think it's time to make check-manifest configurable. I already suggested (in issue #2) a setup.cfg section like

[check-manifest]
ignore = bootstrap.py

I'd appreciate some help with this:

  • what's the formal syntax for setup.cfg? Is it typically parsed with ConfigParser?
  • what's the convention for lists of values in a setup.cfg? Space separated, comma separated, newline-separated?
  • I'd like ignore = ... to add to the default ignore list. There should also be a way to replace the list in its entirety. What would be a good syntax for that?

@gotcha
Copy link
Author

gotcha commented Mar 10, 2013

zest.releaser reads options from setup.cfg

They use ConfigParser.

@mgedmin
Copy link
Owner

mgedmin commented Mar 12, 2013

That answers one of my three questions ;)

@mgedmin
Copy link
Owner

mgedmin commented Mar 14, 2013

Okay, strawman proposal time: use ConfigParser to read setup.cfg like the following example:

[check-manifest]
default-ignore-rules = false
ignore =
    .gitignore
    *.egg-info
    *.mo
    bootstrap.py
    buildout.cfg

I still don't know when I might find the time to work on this.

@mgedmin
Copy link
Owner

mgedmin commented Mar 17, 2013

Fixed in 0.10.

@mgedmin mgedmin closed this as completed Mar 17, 2013
@gotcha
Copy link
Author

gotcha commented Mar 18, 2013

Great ! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants