-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A better rollback when something fails #1
Comments
Hey @mgol, it would definitely be nice to rollback when something fails. |
Hmm, it should be enough to wrap Lines 86 to 89 in e665175
npm publish succeeded and next Git operations failed we can't revert the npm publish (we could unpublish but you can't then re-publish the same version).
Thoughts? Would you like to prepare a PR? |
Or maybe `npm publish` should be moved to be the last operation so that we
always can fully rollback unless we finish all remote operations.
|
@mgol I agree, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If anything throws in a process before we publish on npm, a full rollback should happen (including a
push --force
on a branch to the previous version?)The text was updated successfully, but these errors were encountered: