Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with create-react-app #55

Closed
mifi opened this issue Jun 25, 2017 · 2 comments
Closed

Does not work with create-react-app #55

mifi opened this issue Jun 25, 2017 · 2 comments

Comments

@mifi
Copy link
Contributor

mifi commented Jun 25, 2017

Same issue as #46:
TypeError: querystring.unescape is not a function

But in create-react-app it is not possible to configure bundler (webpack) with aliases. I'm currently using https://github.com/nisaacson/aws-v4-sign-small but it would be nice if aws4 would work out of the box too.

@mhart
Copy link
Owner

mhart commented Jun 25, 2017

This is a bug with webpack – they really shouldn't be bundling such an old version of querystring – probably best to file a bug over there if you haven't already. If create-react-app can't be configured, then that's a limitation with that library as well, so perhaps file over there too.

@mhart
Copy link
Owner

mhart commented Apr 7, 2018

@mifi I included your commit in the latest version of aws4, published as v1.7.0 – thanks, and hopefully this issue won't pop up anymore!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants