Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV Download is inefficient #5

Open
mheadd opened this issue Nov 30, 2016 · 1 comment
Open

CSV Download is inefficient #5

mheadd opened this issue Nov 30, 2016 · 1 comment
Assignees
@mheadd

Comments

@mheadd
Copy link
Owner

mheadd commented Nov 30, 2016

CSV download, as currently designed, works OK but this won't work well if the download is accessed often or if the data grows to a non-trivial size.

Some options:

  • Cache the file so that successive downloads don't pull data from the database each time.
  • Preassemble a CSV file for download, and accessing the /download route just delivers the file. Cold zip it too, to make the download more efficient.
@mheadd mheadd self-assigned this Nov 30, 2016
@mheadd
Copy link
Owner Author

mheadd commented Jan 1, 2017

Node.js streams are worth exploring in this context too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mheadd mheadd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mheadd