Address deepEqual using compare by JSON strings. #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jseter
commented
Oct 21, 2019
jseter
commented
- JSON does not guarantee the ordering that fields are encoded in the string, making it unreliable for generic hashing.
- When ordering is maintained, the strings match the ordering the fields were added to the object, making the unit test too tighly coupled to the order they are added in the implementation.
- A field whose value is undefined versus not being present presents a difference that deepEqual should assert. If it does not matter then possibly a different assert should be used.
added 2 commits
October 21, 2019 11:18
1) JSON does not guarantee the ordering that fields are encoded in the string, making it unreliable for generic hashing. 2) When ordering is maintained, the strings match the ordering the fields were added to the object, making the unit test too tighly coupled to the order they are added in the implementation. 3) A field whose value is undefined versus not being present presents a difference that deepEqual should assert. If it does not matter then possibly a different assert should be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.