Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors in xoshiro128** algorithm #9

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Fix errors in xoshiro128** algorithm #9

merged 1 commit into from
Jul 31, 2024

Conversation

michaeldzjap
Copy link
Owner

Fixes to the xoshiro128** algorithm:

  • Use correct state var for generating new number
  • Fix order of operations for first rotl operation

@michaeldzjap michaeldzjap added the bug Something isn't working label Jul 31, 2024
@michaeldzjap michaeldzjap added this to the Next Major Release milestone Jul 31, 2024
@michaeldzjap michaeldzjap self-assigned this Jul 31, 2024
@michaeldzjap michaeldzjap linked an issue Jul 31, 2024 that may be closed by this pull request
Current Xoshiro128ss implementation is based on an incorrect version 1.0 #8
Closed
@michaeldzjap michaeldzjap merged commit e8f0743 into develop Jul 31, 2024
10 checks passed
@michaeldzjap michaeldzjap deleted the fix/xoshiro128ss branch July 31, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaeldzjap michaeldzjap

Labels
bug Something isn't working
Projects
None yet
Milestone
Next Major Release
Development

Successfully merging this pull request may close these issues.

Current Xoshiro128ss implementation is based on an incorrect version 1.0
1 participant
@michaeldzjap