Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to render multiple waveforms in one page correctly? #19

Closed
jimmyyao88 opened this issue Mar 13, 2021 · 3 comments · Fixed by #25
Closed

How to render multiple waveforms in one page correctly? #19

jimmyyao88 opened this issue Mar 13, 2021 · 3 comments · Fixed by #25

Comments

@jimmyyao88
Copy link

Hello Michael.

I'm trying to place multiple waveforms in a single page like soundcloud.

But everytime I create a waveform it will also create a new waveplayer instance on page which means it will create multiple audio tag elements in page.I have 100+ instance in a single page, and it will increase RAM usage soon.
And use playlist cannot display multiple waveform views in a single page.
I'm wondering how to use a single audio tag(a global context) to make it display multiple waveform view. (to avoid CPU and RAM over usage).

THX!

@jimmyyao88
Copy link
Author

The page looks like soundcloud stream feed.
Screen Shot 2021-03-13 at 8 58 24 PM

@michaeldzjap
Copy link
Owner

Yes, I understand your concerns @jimmyyao88. However, I don't think it is really possible to change this easily without considerable refactoring and rethinking some core design choices. I've had it in the back of my mind for a while now to do a thorough refactoring of waveplayer.js, but this won't happen any time soon. So unfortunately I don't think I'll be able to help you out much, at least not at this point in time.

@jimmyyao88
Copy link
Author

@michaeldzjap Thx for ur reply. I will check the source code and try to refactor. Thank you for bring us this great library!

@michaeldzjap michaeldzjap linked a pull request Jan 1, 2023 that will close this issue
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants