Chromedriver not closing properly

[michaelhball]

          just came back after having my computer off for about eight hours, google chrome has many instances open, so yeah seems to have something to do with that.

Originally posted by @ShiestGuy in #38 (comment)

Hey @ShiestGuy I created a new issue for you here, the place you were posting was for my tracking of a separate issue.

I will investigate this as soon as I can and try to work something out, but in preparation could you please let me know how you're running discogs_alert: which command are you using (docker vs python, etc.), are you running it as a cron job, which interval are you using, how many (roughly) items are in your wantlist etc.

[ShiestGuy]

im running it through python in a command prompt on windows. I don't think I am running it as a cron job, as I open it manually myself, however I do have it open on startup. There are about 30 items in my wantlist.

[michaelhball]

Alright, I'll do my best to work this out this week. Could you also attach some kind of screenshot showing how you know there are many Chrome instances running?

[ShiestGuy]

This is what it looks like after a few instances of powering off and on the computer. Only seems to multiply while powered off.

[michaelhball]

Only seems to multiply while powered off.

Interesting! I suppose it might always be tricky if the computer powers off while the chromedriver is running... That being said, I've pushed a couple of changes that I hope will help.

I found this issue mentioning issues with closing chromedriver.exe on Windows that are specific to a flag I was using, so I've stopped that. And furthermore I realised I wasn't properly shutting down the driver between executions. I'm hoping that the combination of those two changes will make a difference, but I'll leave this issue open until I hear from you that it worked.

As always, you can install the new version with pip install --upgrade discogs_alert

[ShiestGuy]

from what I see, seems to work great! computer isn't running out of RAM and I've had it open for about two days, no multiple chrome instances in the task manager. thanks for fixing it, runs a lot better now!

[michaelhball]

Awesome, enjoy! I'll close the issue