Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: Transaction confirmation timeout #380

Closed
sdevkc opened this issue Dec 29, 2023 · 1 comment
Closed

Question: Transaction confirmation timeout #380

sdevkc opened this issue Dec 29, 2023 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sdevkc
Copy link
Contributor

sdevkc commented Dec 29, 2023

Is there any reason why the default timeout is 30 seconds in confirm_transaction? Although it is impossible to predict the timeout, but wouldn't it make more sense to use 60 - 90 seconds?

https://docs.solana.com/developing/transaction_confirmation#how-does-transaction-expiration-work
@michaelhly
Copy link
Owner

@sdevkc would you mind creating a PR to change it for us? 🙏

@michaelhly michaelhly added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 30, 2023
@sdevkc sdevkc mentioned this issue Dec 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelhly @sdevkc