Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it should allow to build options step by step without overriding previously set values #77

Merged
merged 1 commit into from
Oct 21, 2012

Conversation

tomgi
Copy link
Contributor

@tomgi tomgi commented Oct 21, 2012

See added specs.

I know I could use

f.options[:xAxis][:categories] = [3, 5, 7]
f.options[:xAxis][:title][:text] = 'x title' 

But then I have to be sure that all "middle-hashes" are already initialized and I am not calling []= on nil.

@xiaods
Copy link
Collaborator

xiaods commented Oct 21, 2012

very cool!

michelson added a commit that referenced this pull request Oct 21, 2012
it should allow to build options step by step without overriding previously set values
@michelson michelson merged commit edf35ce into michelson:master Oct 21, 2012
@michelson
Copy link
Owner

merged, thanks!

@tomgi
Copy link
Contributor Author

tomgi commented Oct 22, 2012

Thanks, could you release new version to rubygems?

@xiaods
Copy link
Collaborator

xiaods commented Oct 22, 2012

@tomgi i need keep the release window is smooth, i have not decide to release new one if not urgent case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants