Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

valid_email2 is not validating the emails correctly #88

Closed
sajjadmurtaza opened this issue Oct 26, 2017 · 1 comment
Closed

valid_email2 is not validating the emails correctly #88

sajjadmurtaza opened this issue Oct 26, 2017 · 1 comment

Comments

@sajjadmurtaza
Copy link
Contributor

sajjadmurtaza commented Oct 26, 2017

I tried to validate emails using valid_email2 gem (without ActiveModel) but i noticed there is something that needs to improve.

Look at following examples (Especially email address)

1-

 > email
   => "goel.urvashi1@gmail+blinkist.com" 
 > ValidEmail2::Address.new(email).valid?
   => true 

Why?

2-

 > email
   => "jacoblarsonband@yahoo.comfargoasfsn123!"
 > ValidEmail2::Address.new(email).valid?
   => true 

Why it's saying valid email?

and also for email = "bengmr@msn-.com"

any suggestion will be appreciated. Thanks

@micke micke closed this as completed in c21da3d Oct 26, 2017
@micke
Copy link
Owner

micke commented Oct 26, 2017

I've release v2.1.0 to rubygems with the fix. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants