Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom cmake target: idf.py clean-ros #105

Merged
merged 3 commits into from
Oct 28, 2021
Merged

Conversation

donRaphaco
Copy link
Contributor

adds the custom CMake target clean-ros it's just a shortcut for running make -f libmicroros.mk clean.
You can just run idf.py clean-ros in the project's main directory and don't have to change directories.

@pablogs9
Copy link
Member

Awesome, thanks a lot!

@pablogs9
Copy link
Member

@mergify backport main foxy

@pablogs9
Copy link
Member

Maybe clean-microros? thought @donRaphaco @Acuadros95?

@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2021

backport main foxy

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

Hey, I reacted but my real name is @Mergifyio

@donRaphaco
Copy link
Contributor Author

Maybe clean-microros? thought @donRaphaco @Acuadros95?

agreed 👍

@donRaphaco
Copy link
Contributor Author

Ok that's weird I could create this new branch, but I now when I try to push I get "permission denied".
@pablogs9 I think you have to do the change.

@pablogs9
Copy link
Member

Try again please

README.md Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@donRaphaco
Copy link
Contributor Author

donRaphaco commented Oct 27, 2021

Try again please

@pablogs9 still the same problem. I also don't have the option to apply the suggested changes from @Acuadros95

@Acuadros95
Copy link
Contributor

No problem

@pablogs9 pablogs9 merged commit df431ce into galactic Oct 28, 2021
@pablogs9 pablogs9 deleted the feature/clean-ros-target branch October 28, 2021 05:51
mergify bot pushed a commit that referenced this pull request Oct 28, 2021
* custom cmake target: idf.py clean-ros

* Update CMakeLists.txt

* Update README.md

Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com>
(cherry picked from commit df431ce)
mergify bot pushed a commit that referenced this pull request Oct 28, 2021
* custom cmake target: idf.py clean-ros

* Update CMakeLists.txt

* Update README.md

Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com>
(cherry picked from commit df431ce)
@mergify
Copy link
Contributor

mergify bot commented Oct 28, 2021

backport main foxy

✅ Backports have been created

pablogs9 pushed a commit that referenced this pull request Oct 28, 2021
* custom cmake target: idf.py clean-ros

* Update CMakeLists.txt

* Update README.md

Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com>
(cherry picked from commit df431ce)

Co-authored-by: donRaphaco <fixed-term.Raphael.Vogelgsang@de.bosch.com>
pablogs9 pushed a commit that referenced this pull request Oct 28, 2021
* custom cmake target: idf.py clean-ros

* Update CMakeLists.txt

* Update README.md

Co-authored-by: Antonio Cuadros <49162117+Acuadros95@users.noreply.github.com>
(cherry picked from commit df431ce)

Co-authored-by: donRaphaco <fixed-term.Raphael.Vogelgsang@de.bosch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants