Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong ar command #117

Merged
merged 1 commit into from
Dec 22, 2021
Merged

Fix wrong ar command #117

merged 1 commit into from
Dec 22, 2021

Conversation

RSchwan
Copy link
Contributor

@RSchwan RSchwan commented Dec 22, 2021

On Linux, this change doesn't make a difference, since the gnu binutils are more or less the same as the bundled ones, but on macOS the system ar is different, leading to compilation errors.

@pablogs9
Copy link
Member

Thanks a lot for this patch! Merging when the CI pass

@pablogs9
Copy link
Member

@mergify backport foxy main

@mergify
Copy link
Contributor

mergify bot commented Dec 22, 2021

backport foxy main

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

Hey, I reacted but my real name is @Mergifyio

@pablogs9 pablogs9 merged commit 4191a31 into micro-ROS:galactic Dec 22, 2021
mergify bot pushed a commit that referenced this pull request Dec 22, 2021
(cherry picked from commit 4191a31)
mergify bot pushed a commit that referenced this pull request Dec 22, 2021
(cherry picked from commit 4191a31)
@mergify
Copy link
Contributor

mergify bot commented Dec 22, 2021

backport foxy main

✅ Backports have been created

pablogs9 pushed a commit that referenced this pull request Dec 22, 2021
(cherry picked from commit 4191a31)

Co-authored-by: Roland Schwan <RSchwan@users.noreply.github.com>
pablogs9 pushed a commit that referenced this pull request Dec 23, 2021
(cherry picked from commit 4191a31)

Co-authored-by: Roland Schwan <RSchwan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants