Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a way to allow all URL schemes? #174

Closed
yardenshoham opened this issue May 13, 2023 · 3 comments · Fixed by #175
Closed

Is there a way to allow all URL schemes? #174

yardenshoham opened this issue May 13, 2023 · 3 comments · Fixed by #175

Comments

@yardenshoham
Copy link
Contributor

yardenshoham commented May 13, 2023

Basically something like AllowURLSchemeWithCustomPolicy but for all schemes.

References:

@yardenshoham yardenshoham changed the title Is there a way to a llow all custom URL schemes? Is there a way to allow all custom URL schemes? May 13, 2023
@yardenshoham yardenshoham changed the title Is there a way to allow all custom URL schemes? Is there a way to allow all URL schemes? May 13, 2023
@grafana-dee
Copy link
Contributor

Today there isn't.

It would probably require the addition of AllowURLSchemesRegexp(r regexp) and then instead of matching a fixed set of strings it would match the regexp. To allow all you'd merely set a regexp to .*.

If you wanted to make a working PR with a test for it, I would accept it.

@yardenshoham
Copy link
Contributor Author

@grafana-dee
Copy link
Contributor

Thanks, I've been snowed under with a fairly large incident the last few days, but I've just taken a look and this is great so I'll merge now and will cut a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants