-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Automatic-Module-Name to all manifest files #1242
Comments
It would be great get this introduced in some form to lessen the warnings seen when building projects in JDK9+, e.g.
|
Seems we have a decision to make regarding what our automatic-module-names specifically are. I'm seeing 3 likely options:
I'm leaning towards one of the latter two, even though it would differ from the implicit automatic-module-names now. |
I would go with first or second personally, and probably the first is best IMHO. |
I have gone with the short project names which will match the filename-based automatic modules. This should not break any existing users of our automatic modules. |
While we haven't modularized Micrometer itself, we can still set a stable automatic module name for each of our produced artifacts and declare it in the manifest file. This will ensure the Micrometer artifacts' module names can be reliably used by those who are modularizing their applications and using Micrometer.
There seem to be two formulas folks are using to pick their module names. Without an Automatic-Module-Name specified or an actual module-info file, the JAR file name will be used to make an automatic module by converting hyphens
-
to dots.
. Some choose to make this their declared automatic module name (e.g.spring.beans
); others choose to add in their group ID in front of this (e.g.org.junit.jupiter.api
).Note: If there are users on the module path depending on our JAR name-derived automatic module name, we would break them by choosing something else - they would have to change the name when upgrading to the version we declare something else explicitly to be our module name.
See https://dzone.com/articles/automatic-module-name-calling-all-java-library-maintainers
The text was updated successfully, but these errors were encountered: