Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused OTel Logging Exporter dependency #562

Closed
ciscoo opened this issue Jan 30, 2024 · 3 comments
Closed

Remove unused OTel Logging Exporter dependency #562

ciscoo opened this issue Jan 30, 2024 · 3 comments
Labels
type: task A general task
Milestone

Comments

@ciscoo
Copy link

ciscoo commented Jan 30, 2024

https://github.com/micrometer-metrics/tracing/blob/94d1143ab9b18db09166142733d8e3427952f79d/micrometer-tracing-bridges/micrometer-tracing-bridge-otel/build.gradle#L16C32-L16C62

Per the README:

This exporter is being deprecated in favour of the debug exporter. It will be removed in September 2024.

@shakuzen
Copy link
Member

shakuzen commented Feb 6, 2024

Thank you for bringing this to our attention. I'm not sure if that dependency is being used currently. I tried removing it on main and the build still passes. @marcingrzejszczak or @jonatan-ivanov do you know?

@marcingrzejszczak
Copy link
Contributor

Hmm I don't recall that being used.

@shakuzen shakuzen added the type: task A general task label Feb 6, 2024
@shakuzen shakuzen changed the title Replace deprecated OTEL Logging Exporter with Debug Exporter Remove deprecated OTEL Logging Exporter optional dependency Feb 6, 2024
@jonatan-ivanov
Copy link
Member

I think we might discuss about two things here:

  1. io.opentelemetry:opentelemetry-exporter-logging (written in java, part of the OTel Java SDK, Maven Central, source)
  2. Logging exporter (written in Go, part of the OTel collector, source)

Deprecating the collector module (#2) should have no effect on Micrometer Tracing, I guess @ciscoo meant the dependency (#1) but found the wrong deprecation note, the dependency should be stable and not deprecated.

Though that dependency seems unused as @shakuzen found out, I think it was only added for testing/troubleshooting/development purposes (with the first PR) and we forgot to remove.
I think we should remove it. @ciscoo Thank you for bringing this to our attention!

@jonatan-ivanov jonatan-ivanov changed the title Remove deprecated OTEL Logging Exporter optional dependency Remove unused OTel Logging Exporter dependency Feb 6, 2024
@jonatan-ivanov jonatan-ivanov added this to the 1.0.13 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

4 participants