Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to Micronaut 4.3.8 #3611

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

loicmathieu
Copy link
Member

Fixes micronaut-projects/micronaut-core#3553

Using the trick explained here to use a different cookie encoder to fix micronaut-projects/micronaut-security#1683

Copy link

sonarcloud bot commented Apr 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sdelamo
Copy link

sdelamo commented Apr 24, 2024

does using io.micronaut.http.cookie.DefaultServerCookieEncoder fixes the null RouteMatch you were seeing?

@loicmathieu
Copy link
Member Author

We still need to validate, it's not easily reproducible in local.
I'll update the Micronaut issue as soon as we know if it fixes the issue or not.

@loicmathieu loicmathieu merged commit 82bde21 into develop Apr 25, 2024
6 checks passed
@loicmathieu loicmathieu deleted the feat/upgrade-micronaut branch April 25, 2024 12:28
@loicmathieu
Copy link
Member Author

@sdelamo we try it and it didn't fix the issue.

@tchiotludo
Copy link
Member

tchiotludo commented Apr 25, 2024

@sdelamo, no the bugfix was release today and it's still happening.
We deploy and we still have unauthorized response.
Even our demo is failing even with private navigation, just do on https://demo.kestra.io and you will see unauthorized response on refresh really easily.
So, since even on private navigation it's still failing, the cookie don't seems to be the main reason.
If you have anything we can share to help, but I'm not able to create a simple reproducer, just 100% reproduced on the deployed / env (and local)
Doing a siege benchmark, we have 1 to 5% of the request failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants