Update to latest otel #2257
Update to latest otel #2257
Conversation
|
Is this open-telemetry/opentelemetry-java#4381 fixed in 1.14? Just curious so that I can work on that. |
It's not fixed yet, but I think you can start working on using upstream micrometer instrumentation, and we can mitigate that issue in our distro if needed by setting the logging level for |
trask
force-pushed
the
update-to-latest-otel
branch
3 times, most recently
from
4f05bc7 to
575421c
Compare
trask
force-pushed
the
update-to-latest-otel
branch
from
575421c to
29c638e
Compare
...gent/instrumentation/applicationinsightsweb/ApplicationInsightsWebInstrumentationModule.java
Show resolved
Hide resolved
...gent/instrumentation/applicationinsightsweb/ApplicationInsightsWebInstrumentationModule.java
Show resolved
Hide resolved
...telemetry/javaagent/instrumentation/applicationinsightsweb/ThreadContextInstrumentation.java
Show resolved
Hide resolved
trask
force-pushed
the
update-to-latest-otel
branch
2 times, most recently
from
cce493a to
9ab9a3a
Compare
trask
force-pushed
the
update-to-latest-otel
branch
from
9ab9a3a to
8b328dc
Compare
| - '**/build/libs/*.jar' | ||
| - '**/build/libs/*-sources.jar' | ||
| - '**/build/libs/*-javadoc.jar' | ||
| - '**/build/libs/*.pom' | ||
| exclude: | ||
| - 'buildSrc/**/*' | ||
| - '~/.m2/repository/com/microsoft/azure/applicationinsights-agent/*/*.jar' | ||
| - '~/.m2/repository/com/microsoft/azure/applicationinsights-agent/*/*-sources.jar' | ||
| - '~/.m2/repository/com/microsoft/azure/applicationinsights-agent/*/*-javadoc.jar' | ||
| - '~/.m2/repository/com/microsoft/azure/applicationinsights-agent/*/*.pom' |
There was a problem hiding this comment.
@heyams I'm still debugging smoke test failure, but can you take a look at the changes I needed to make to pipelines b/c sources/javadocs/pom are no longer built under build/libs, but rather only built using publishToMavenLocal under ~/.m2
There was a problem hiding this comment.
all these yml(s) need to be updated.
There was a problem hiding this comment.
release pipeline needs to to be updated too. jarPath is different with this change.
There was a problem hiding this comment.
jar is still built to same place, just the source/javadoc/pom file no longer get build there
There was a problem hiding this comment.
looks good to me on the yml.. I will update later once you merge if needed.
| - '**/build/libs/*.jar' | ||
| - '**/build/libs/*-sources.jar' | ||
| - '**/build/libs/*-javadoc.jar' | ||
| - '**/build/libs/*.pom' | ||
| exclude: | ||
| - 'buildSrc/**/*' | ||
| - 'agent/agent/build/libs/*.jar' |
There was a problem hiding this comment.
this is fine without including pom, sources, and javadoc.. that's for maven publish.
| - '**/build/libs/*.jar' | ||
| - '**/build/libs/*-sources.jar' | ||
| - '**/build/libs/*-javadoc.jar' | ||
| - '**/build/libs/*.pom' | ||
| exclude: | ||
| - 'buildSrc/**/*' | ||
| - 'agent/agent/build/libs/*.jar' |
There was a problem hiding this comment.
this is fine without including pom, sources, and javadoc..
| @@ -16,13 +16,11 @@ build: | |||
| - !!buildcommand | |||
| name: 'Assemble ApplicationInsights-Java JARs' | |||
| command: '.scripts/gradle.cmd' | |||
| arguments: 'assemble copyLibsToGlobalArtifactsFolder -DisRelease=true -Pai.etw.native.build=release' | |||
| arguments: 'publishToMavenLocal -DisRelease=true -Pai.etw.native.build=release' | |||
There was a problem hiding this comment.
why do you want to use 'publishToMavenLocal' for builds? can we keep the old one? what is the reason of this change?
There was a problem hiding this comment.
publishToMavenLocal is the standard way to build javadoc/sources/pom, what we were doing previously was non-standard
trask
force-pushed
the
update-to-latest-otel
branch
from
5c26f4e to
199de7c
Compare
|
copyBitsToAzureBlob.ps1 will fail due to source, and pom path change. |
|
copyBitsToAzureBlob.ps1 is used in the release pipeline. |
Includes fix for problematic jdbc wrapper